-
Notifications
You must be signed in to change notification settings - Fork 136
Newpkg: Lugaru #1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Newpkg: Lugaru #1811
Conversation
|
@robertkirkman @hansm629 All known bugs fixed, please check :) |
tur/lugaru/build.sh
Outdated
| TERMUX_PKG_HOMEPAGE=https://osslugaru.gitlab.io | ||
| TERMUX_PKG_DESCRIPTION="Lugaru HD, free and open source ninja rabbit fighting game" | ||
| TERMUX_PKG_LICENSE="GPL-2.0" | ||
| TERMUX_PKG_MAINTAINER="@termux-user-repository" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to set yourself as maintainer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@licy183
Thanks for reply. Should that be the Github nickname or the actual nickname? Probably the github one due to the fact that the bot will call me if the package doesn't work, but I prefer to inquire
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be the nickname on GitHub.
robertkirkman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The game is working very very well, and the framerate is really great with Zink + Turnip on Adreno 612. The audio and music are also both working!
It's disappointing that this game doesn't have any touchscreen buttons, but since it is open source, some day I could make some. I am trying to make some other projects other than touchscreen buttons currently.
Could you change the PR description and commit history to explain that the audio issue is fixed by the patch?
|
This game does capture the Termux:X11 cursor inescapably and if you don't have a physical, hardware keyboard, it will unfortunately trap the Termux:X11 cursor inescapably. however, the Android OS cursor will still work and it will allow you to go to Termux App and type Unfortunately, this problem is just the kind of thing that is common to all games generally that don't have any touchscreen buttons implemented. On a touchscreen-only device, including GNU/Linux as well, there are a lot of unreachable inputs and the game is unplayable. |
Well, I use lapdock. However the other way is to add touchscreen on top of screen. Termux-x11-extra can do that, but a code have some Bugs to upstream to termux-x11 |
| TERMUX_PKG_SHA256=f3ea477caf78911c69939fbdc163f9f6517c7ef2267e716a0e050be1a166ef97 | ||
| TERMUX_PKG_DEPENDS="sdl2, glu, openal-soft, lugaru-data" | ||
| TERMUX_PKG_EXTRA_CONFIGURE_ARGS=" | ||
| -DCMAKE_INSTALL_PREFIX=$TERMUX_PREFIX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is automatically applied by termux_step_configure_cmake() and is not necessary to specify explicitly here.
| -DSYSTEM_INSTALL=ON | ||
| -DCMAKE_INSTALL_BINDIR=bin | ||
| -DCMAKE_INSTALL_DATADIR=share/games | ||
| -DCMAKE_POLICY_VERSION_MINIMUM=3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This additional patch is also necessary in order to fix the second error that occurs with CMake 4:
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,7 +1,6 @@
project(lugaru)
cmake_minimum_required(VERSION 3.0)
-cmake_policy(SET CMP0004 OLD)
include(FindPkgConfig)
include(GNUInstallDirs)
Known issues:
@robertkirkman